Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.ValueTuple dependency is causing versioning issues after updating to NetStandard/NetCore #1687

Closed
nicosijtsma opened this issue Apr 12, 2021 · 1 comment · Fixed by #2012

Comments

@nicosijtsma
Copy link

<PackageReference Include="System.ValueTuple" Version="4.5.0" />

As System.ValueTuple is part of the .NET 4.7 and .NET Standard framework, it should not be necessary to reference the package in the project

Our projects are reporting below warning
Warning MSB3277: Found conflicts between different versions of "System.ValueTuple" that could not be resolved.

This should be resolved by removing the System.ValueTuple NuGet dependency from the package.

@adamsitnik
Copy link
Member

We had a lot of issues with similar .NET Standard dependencies in the past. (#667, #895, #1160)

They were all caused by VS which was generating wrong assembly binding redirects. The solution was to just remove what the VS has generated. There is very little we can do about the VS, but if you are willing to send a PR and test it against:

  • .NET 4.6.1 project using "classic" csproj
  • .NET 4.6.1 project using "modern" csproj
  • .NET Core 2.1

I am open to removing this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants