Release preview for 4.0.0+ #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove buyProduct. - Remove buySubscription. - Remove buyProductWithOfferIOS. - Remove buyProductWithQuantityIOS. - Remove addAdditionalSuccessPurchaseListenerIOS. - Rename requestReceiptIOS to getReceiptIOS. - Rename buyProductWithOfferIOS to requestPurcaseWithOfferIOS. - Rename buyProductWithQuantityIOS to requestProductWithQuantityIOS.
- It abstracts `finishTransactionIOS`, `consumePurchaseAndroid`, `acknowledgePurchaseAndroid` in to one method.
- Add `deveoperId` and `accountId` when requesting `purchase` or `subscription` in `android`. Find out more in `requestPurchase` and `requestSubscription`.
- Fix prorationMode param and null activity.
- Send `purchase-error` with null purchases.
Stafox
referenced
this pull request
in vovkasm/react-native-iap
Sep 24, 2019
On iOS transactionId corresponds to native transactionId. On Android transactionId corresponds to purchaseToken. From docs: "A token that uniquely identifies a purchase for a given item and user pair". Use it as transactionId because it used in later api calls.
These were added as part of #616 but the flow file never got updated
As you requested :)
|
Great to see this happening @hyochan! Thanks for this! I noticed a typo, don't know if it's easily fixable but you say when you actually did the opposite and correct thing by changing it to false. |
hyochan
referenced
this pull request
Oct 14, 2019
|
@solidfox Yes you are right! I think I've missed this out when migrating to |
marzuq-adebayo-dev
referenced
this pull request
in marzuq-adebayo-dev/React-Native-iap
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buyProduct.buySubscription.addAdditionalSuccessPurchaseListenerIOS.requestReceiptIOStogetReceiptIOS.buyProductWithOfferIOStorequestPurcaseWithOfferIOS.buyProductWithQuantityIOStorequestProductWithQuantityIOS.finishTransactionIOS,consumePurchaseAndroid,acknowledgePurchaseAndroidin to one method.developerIdandaccoundIdwhen requestingpurchaseorsubscription.tsproject.dep.eslintusing@dooboo/eslint-config.