Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility between gitsome and haxor-news #21

Closed
jashgala opened this issue May 11, 2016 · 3 comments
Closed

Compatibility between gitsome and haxor-news #21

jashgala opened this issue May 11, 2016 · 3 comments

Comments

@jashgala
Copy link
Contributor

It seems that both these use different versions of the prompt-toolkit which does not allow both to coexist simultaneously.

haxor-news uses 0.52
gitsome uses 0.51

I hope this compatibility issue can be resolved!

(I don't know if this is a valid issue to be posted here. But since they are both awesome tools developed by the same developer, I think this is a good place to post it.)

@jashgala
Copy link
Contributor Author

jashgala commented May 11, 2016

I know this may sound reckless. I replaced the prompt-toolkit version requirement in gitsome with 0.52 and rebuilt (in the setup.py and in requires.txt).

Apparently the versions are compatible with each other.

It fixed this issue. Should I create a pull-request?

@donnemartin
Copy link
Owner

donnemartin commented May 11, 2016

Sure, thanks for the feedback!

A pull request would be great.

Here's what changed from 0.51 to 0.52:

0.52: 2015-09-24
----------------

Fixes:
- Fix in auto suggestion: hide suggestion when accepting input.

Can you also verify auto suggestions still work properly?

https://github.com/donnemartin/gitsome#fish-style-auto-suggestions

@donnemartin
Copy link
Owner

Fixed with ba3d2a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants