Add params and literals methods to InsertBuilder, UpdateBuilder and DeleteBuilder #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add params and literals methods to InsertBuilder, UpdateBuilder and DeleteBuilder
nakamura-to
requested changes
Apr 11, 2021
|
|
||
| @Test | ||
| public void testParams() throws Exception { | ||
| UpdateBuilder builder = UpdateBuilder.newInstance(new MockConfig()); |
There was a problem hiding this comment.
I think DeleteBuilder is correct in this test class.
There was a problem hiding this comment.
I apologize.
I just fixed now.
added 3 commits
April 11, 2021 21:35
Correcting mistakes(UpdateBuilder -> DeleteBuilder)
format code
fix the unnecessary changes by code completion
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#679
Please consider merging them if this request is not against doma's policy.