Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docz,docz-theme-default): remove react & react-dom from dependencies #924

Closed
wants to merge 4 commits into from
Closed

fix(docz,docz-theme-default): remove react & react-dom from dependencies #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16ef637
fix(docz): remove react & react-dom from dependencies (#923)
MunifTanjim Jun 18, 2019
3056e2f
fix(docz-theme-default): rm react{,-dom} from dependencies (#923)
MunifTanjim Jun 18, 2019
dd09694
docs: update README.md
MunifTanjim Jun 18, 2019
c315e75
fix(gatsby-theme-docz): move react & react-dom to peerDependencies
MunifTanjim Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,15 @@ Getting started with **Docz** is really quick and easy.
Firstly, install `docz` and a theme of your choosing using your favourite package manager:

```bash
$ yarn add --dev docz docz-theme-default
$ yarn add --dev docz docz-theme-default react react-dom

# or

$ npm install --save-dev docz docz-theme-default
$ npm install --save-dev docz docz-theme-default react react-dom
```

**Note**: `react` and `react-dom` will not be installed automatically. You'll have to install them yourself.

Next, add some `.mdx` files anywhere inside your project:

```markdown
Expand Down
2 changes: 0 additions & 2 deletions core/docz-theme-default/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@
"polished": "^3.3.0",
"prop-types": "15.7.2",
"re-resizable": "^4.11.0",
"react": "^16.8.6",
"react-codemirror2": "^6.0.0",
"react-dom": "^16.8.6",
"react-feather": "^1.1.6",
"react-live": "2.0.1",
"react-perfect-scrollbar": "^1.5.0",
Expand Down
2 changes: 0 additions & 2 deletions core/docz/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
"lodash": "^4.17.11",
"match-sorter": "^3.0.0",
"prop-types": "^15.7.2",
"react": "^16.8.6",
"react-dom": "^16.8.6",
"ulid": "^2.3.0",
"yargs": "^13.2.2"
},
Expand Down
6 changes: 4 additions & 2 deletions core/gatsby-theme-docz/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
"gatsby-plugin-styled-components": "^3.0.7",
"lodash": "^4.17.11",
"prop-types": "^15.7.2",
"react": "^16.8.6",
"react-dom": "^16.8.6",
"react-helmet": "^5.2.1",
"rehype-docz": "^1.2.0",
"rehype-slug": "^2.0.2",
Expand All @@ -54,5 +52,9 @@
"eslint-plugin-jsx-a11y": "6.2.1",
"eslint-plugin-react": "7.13.0",
"eslint-plugin-react-hooks": "^1.6.0"
},
"peerDependencies": {
"react": "^16.8.0",
"react-dom": "^16.8.0"
}
}