Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docz,docz-theme-default): remove react & react-dom from dependencies #924

Closed
wants to merge 4 commits into from
Closed

fix(docz,docz-theme-default): remove react & react-dom from dependencies #924

wants to merge 4 commits into from

Conversation

MunifTanjim
Copy link

Description

fixes #923

@draperunner
Copy link

#882 aims to solve the same issue. I made a comment there to solve it like you did here, @MunifTanjim. But it seems @saimonmoore hasn't updated his PR yet.

@MunifTanjim I guess you also should remove react, react-dom from gatsby-theme-docz's dependencies.

@draperunner
Copy link

Also, you should update the installation instructions in README.md now that react and react-dom need to be installed as peers.

@MunifTanjim
Copy link
Author

I guess you also should remove react, react-dom from gatsby-theme-docz's dependencies.

Already did.

Also, you should update the installation instructions in README.md now that react and react-dom need to be installed as peers.

Done!

@draperunner
Copy link

Hm, I can't see that you've changed anything for gatsby-theme-docz. Are you confusing it with docz-theme-default? gatsby-theme-docz doesn't even have any peerDependencies, so I think they need to be added there and removed from dependencies.

@MunifTanjim
Copy link
Author

MunifTanjim commented Jun 18, 2019 •
edited
Loading

Hm, I can't see that you've changed anything for gatsby-theme-docz. Are you confusing it with docz-theme-default?

You are absolutely right 😲 So sorry about that.

I've opened PR about the same issue on gatsbyjs/gatsby & mdx-js/mdx too. I mixed it up in my head 😂

gatsby-theme-docz doesn't even have any peerDependencies, so I think they need to be added there and removed from dependencies.

Done! 😅

draperunner
draperunner approved these changes Jun 18, 2019
View reviewed changes
Copy link

@draperunner draperunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :D

I hope @pedronauck will merge this. I think it will potentially close #837, #707 and #882

@pedronauck pedronauck changed the base branch from dev to feat/gatsby July 11, 2019 12:40
pedronauck added a commit that referenced this pull request Jul 11, 2019
@pedronauck
fix: remove react & react-dom from dependencies #924
faf4288
@pedronauck
Copy link
Member

Merged manually into feat/gatsby.

@pedronauck pedronauck closed this Jul 11, 2019
@draperunner draperunner mentioned this pull request Jul 18, 2019
Merged
3 tasks
pedronauck added a commit that referenced this pull request Jul 18, 2019
@pedronauck
🚀 Introduce v2 (#950)
cfe07b0 
* feat(docz-core): add initial gatsby bundler algorithm

* chore: update yarn.lock

* feat: docz running using gatsby under the hood

* chore(docz-core): refactor devserver machine

* chore(docz-core): some improvements

* fix(docz-core): some adjustments

* fix(babel-plugin-export-metadata): disable enumerable for __filemeta

* chore: update dependencies

* feat(docz-core): add doczrc config watcher on dev

* chore(docz-core): remove unnecessary file

* fix: packages rollup config

* feat(docz-core): add build and serve command with gatsby

* chore: update dependencies

* chore(docz-core): remove unnecessary babel config

* feat: dynamic src and root path

* chore: update dependencies

* feat: add typescript support (need fix)

* chore: use emotion instead of styled-components

* chore: add first steps with theme-ui

* chore(docz-theme-default): some modes adjustments

* chore: use theme default as theme component shadowing

* feat: add main package improvements

* chore: update dependencies

* chore: update dependencies

* chore: remove styled-components from examples

* feat: add new theme sidebar

* fix(gatsby-theme-docz): entry not in context

* chore(gatsby-theme-docz): change project structure

* fix: eslint configs

* chore(gatsby-theme-docz): change main layout

* feat(gatsby-theme-docz): add new Props component

* feat(gatsby-theme-docz): add new Pre component

* chore: update dependencies

* feat: add new Playground component

* feat(gatsby-theme-docz): add blockquote styles

* chore(gatsby-theme-docz): just some adjustments

* feat(gatsby-theme-docz): add some improvements

* chore: udpate dependencies

* feat: a lot of improvements

* chore: update dependencies

* chore: some improvements

* chore: update dependencies

* feat: adapt core plugins to gatsby hooks

* feat(docz-core): watch gatsby config files

* fix: no-undef eslint rule

* feat(gatsby-theme-docz): improve code highlight

* chore: just some adjustments

* fix(gatsby-theme-docz): prisms theme by themeConfig

* feat(docz-core): watch custom theme files

* chore: update dependencies

* chore: update dependencies

* fix: some typescript adjustments

* feat(docz-core): ensure files before running machine

* chore: remove codesandbox feature

* feat: some playground improvements

* feat: open browser integration

* chore: remove unused config arguments

* chore: update dependencies

* fix(babel-plugin-export-metadata): transform to Unix slash (#825) (#829)

transform Windows backslash to Unix slash

* feat(gatsby-theme-docz): add showLiveError on Playground

* feat: add markdown parsing on props description

* fix(remark-docz): fix alias in the src of a mdx's image #897

* fix(docz): component Props false positives when looking in state

* fix: remove react & react-dom from dependencies #924

* fix(babel-plugin-export-metadata): fix root relative path

* feat(gatsby-theme-docz): add iframe and re-resizable on playground

* chore: some adjustments

* fix(docz): parse description of props

* feat(gatsby-theme-docz): improve documentation

* docs(gatsby-theme-docz): improve readme

* chore(gatsby-theme-docz): add menu button outside header

* docs: update README

* chore: update migration guide

* chore: some changes on migration guide

* fix: on create webpack plugin hook

* docs: add some info on migration guide

* docs: improve some docs

* feat(gatsby-theme-docz): add custom logo support

* chore: some improvements

* chore(babel-plugin-export-metadata): update snapshots

* chore: update snapshots

* chore: exclude some files from examples

* chore: update dependencies

* fix(docz-core): create deps algorithm

* fix(docz): props markdown compiler

* fix(gatsby-theme-docz): resizable import

* chore(gatsby-theme-docz): logo font family

* chore: remove docz-theme-default dependency

* chore(docz): remove async playground

* docs(gatsby-theme-docz): some changes

* chore: update dependencies

* docs: some adjustments

* fix: resizable props import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedronauck pedronauck pedronauck approved these changes

@draperunner draperunner draperunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MunifTanjim @draperunner @pedronauck