Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docz-core): forward cli status code properly #1319

Merged
merged 1 commit into from
Dec 14, 2019
Merged

fix(docz-core): forward cli status code properly #1319

merged 1 commit into from
Dec 14, 2019

Conversation

adbayb
Copy link
Contributor

@adbayb adbayb commented Dec 13, 2019

Description

Currently, spawned processes (for example, gatsby build) run through CLI don't forward error code correctly to the parent process (docz build) producing success code (eg. 0) even if some child processes failed.
It can be problematic especially if we rely on it to do some CI/CD (like building a Docker image).
This PR solves the issue by forwarding properly child error code on build and serve commands.

Screenshots

See echo $? output.

Before After
Capture d’écran 2019-12-13 à 17 19 50 Capture d’écran 2019-12-13 à 17 15 50

@rakannimer
Copy link
Contributor

This is very helpful ! Thanks 😄 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants