Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added method to be able to reuse the console application #1069

Merged
merged 3 commits into from
Aug 4, 2014
Merged

added method to be able to reuse the console application #1069

merged 3 commits into from
Aug 4, 2014

Conversation

anho
Copy link

@anho anho commented Jun 24, 2014

This comes in handy, when you want to do more with the actual application object then just to run it.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3186

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

@anho shouldn't you just setup the CLI application on your own instead?

@anho
Copy link
Author

anho commented Jun 26, 2014

Sure, I could. But actually I want to reuse existing code, even if there are only a few lines of code.

@Ocramius
Copy link
Member

Thought a bit more about this and it makes sense indeed. I'd need you to do following before merge though:

  • add a test case for the newly introduced method (just needs to test that an application is indeed created, doesn't need to run it)
  • add documentation for the new feature (if needed, please check the existing docs)

@anho
Copy link
Author

anho commented Jul 24, 2014

Here we go.

@Ocramius Ocramius self-assigned this Aug 4, 2014
Ocramius added a commit that referenced this pull request Aug 4, 2014
added method to be able to reuse the console application
@Ocramius Ocramius merged commit 723529f into doctrine:master Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants