Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResultStatement#fetchAll() must define 3 arguments in order to be compatible with PDOStatement#fetchAll() #2519

Closed
phansys opened this issue Sep 22, 2016 · 1 comment · Fixed by #2527
Closed

ResultStatement#fetchAll() must define 3 arguments in order to be compatible with PDOStatement#fetchAll() #2519

phansys opened this issue Sep 22, 2016 · 1 comment · Fixed by #2527
Assignees
@Ocramius
Labels
BC Break Drivers Improvement PDO
Milestone
2.6.0

Comments

@phansys
Copy link
Contributor

phansys commented Sep 22, 2016

ResultStatement::fetchAll() must define 3 arguments, like \PDOStatement::fetchAll().
Even, there is a signature violation at PDOStatement::fetchAll(), where \PDOStatement is extended and Statement interface is implemeted; this finally extends ResultStatement.

I know this change is a BC break, but IMO the current implementation is wrong given what I'm exposing here.
This was referenced Oct 1, 2016
Merged
Closed
@Ocramius Ocramius added this to the 2.6 milestone Jun 6, 2017
@Ocramius Ocramius self-assigned this Jun 6, 2017
@Ocramius Ocramius changed the title [RFC] ResultStatement::fetchAll() must define 3 arguments ResultStatement#fetchAll() must define 3 arguments in order to be compatible with PDOStatement#fetchAll() Jul 22, 2017
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
BC Break Drivers Improvement PDO
Projects
None yet
Milestone
2.6.0
2 participants
@Ocramius @phansys