Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix terminology: "Base image" vs. "Parent Image" #2967

Closed
michael-holzheu opened this issue Apr 20, 2017 · 12 comments
Closed

Doc: Fix terminology: "Base image" vs. "Parent Image" #2967

michael-holzheu opened this issue Apr 20, 2017 · 12 comments
Labels
area/engine Issue affects Docker engine/daemon lifecycle/locked
Milestone

Comments

@michael-holzheu
Copy link

michael-holzheu commented Apr 20, 2017

From the documentation of Base image:

Definition of: base image

An image that has no parent is a base image.

From the documentation of Dockerfile:

Docker runs instructions in a Dockerfile in order. The first instruction must be FROM in order to specify the Base Image from which you are building.

Since the image that is specified via FROM can already be a derived image, it is probably better to say:

Docker runs instructions in a Dockerfile in order. The first instruction must be FROM in order to specify the parent image from which you are building.

Besides this, there are multiple other occurrences of the term "base image" that should be checked.

And also check the following broken link that is used in https://docs.docker.com/engine/reference/builder as link for "Base Image": https://docs.docker.com/engine/reference/glossary/#base-image

@surajnarwade
Copy link
Contributor

@londoncalling this is nice catch, I am claiming this

@surajnarwade
Copy link
Contributor

@michael-holzheu , I am not able to find a file regarding dockerfile reference in repo, can you point me towards that ?
cc @londoncalling

@michael-holzheu
Copy link
Author

@michael-holzheu , I am not able to find a file regarding dockerfile reference in repo, can you point me towards that ?

Not sure what you mean with "file". I just referred to the web pages.

@surajnarwade
Copy link
Contributor

@michael-holzheu , file as in markdown file for that page in repo

@michael-holzheu
Copy link
Author

@michael-holzheu , file as in markdown file for that page in repo

So your question is "where is the markdown file for https://docs.docker.com/engine/reference/builder", right?
I checked out https://github.com/docker/docker.github.io but couldn't not find the markdown file either.

@michael-holzheu
Copy link
Author

I think it is in the docker repository: https://github.com/moby/moby/blob/master/docs/reference/builder.md

@joaofnfernandes joaofnfernandes added the area/engine Issue affects Docker engine/daemon label Apr 21, 2017
@londoncalling
Copy link
Contributor

londoncalling commented Apr 21, 2017

@surajnarwade were you able to find this file per @michael-holzheu 's comment ^^? You'll need to clone the https://github.com/moby/moby/ repository for this one, since some reference files live with the codebase, but the process for creating the PR and making updates is the same.

@surajnarwade
Copy link
Contributor

@londoncalling sure, I will do that

@johndmulhausen
Copy link

Note: Please do not link to /engine/reference/glossary/ anywhere.

@AliBayatGH
Copy link

Both image types allow us to create a reusable image. However, base images allow us more control over the contents of the final image.

@Coder0-0
Copy link

Coder0-0 commented Apr 18, 2020

Thank you for sharing!! @michael-holzheu

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked

@docker docker locked and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/engine Issue affects Docker engine/daemon lifecycle/locked
Projects
None yet
Development

No branches or pull requests

9 participants