Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the name of the exe that's trying to be executed #21345

Merged
merged 1 commit into from
Mar 21, 2016

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Mar 19, 2016

so that the user knows what's not in the container but should be.
Its not always easy for the user to know what exact command is being run
when the 'docker run' is embedded deep in something else, like a Makefile.
Saw this while dealing with the containerd migration.

Signed-off-by: Doug Davis dug@us.ibm.com

@thaJeztah
Copy link
Member

Think this fixes, or at least improves #20789

@thaJeztah
Copy link
Member

(I think)

@duglin
Copy link
Contributor Author

duglin commented Mar 20, 2016

something is definitely funky with the builds these days

@icecrime
Copy link
Contributor

CI failures seem related, aren't they?

@icecrime icecrime added status/2-code-review status/failing-ci Indicates that the PR in its current state fails the test suite and removed status/0-triage labels Mar 20, 2016
so that the user knows what's not in the container but should be.
Its not always easy for the user to know what exact command is being run
when the 'docker run' is embedded deep in something else, like a Makefile.
Saw this while dealing with the containerd migration.

Signed-off-by: Doug Davis <dug@us.ibm.com>
@duglin
Copy link
Contributor Author

duglin commented Mar 21, 2016

Fixed

@duglin duglin removed the status/failing-ci Indicates that the PR in its current state fails the test suite label Mar 21, 2016
@vdemeester
Copy link
Member

LGTM 🐮

@thaJeztah
Copy link
Member

LGTM

thaJeztah added a commit that referenced this pull request Mar 21, 2016
Add the name of the exe that's trying to be executed
@thaJeztah thaJeztah merged commit 02a90d0 into moby:master Mar 21, 2016
@duglin duglin deleted the BetterError branch March 22, 2016 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants