Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake should not install librabit.a when running make install #6092

Closed
hcho3 opened this issue Sep 7, 2020 · 1 comment
Closed

CMake should not install librabit.a when running make install #6092

hcho3 opened this issue Sep 7, 2020 · 1 comment
Assignees
@hcho3

Comments

@hcho3
Copy link
Collaborator

hcho3 commented Sep 7, 2020

Currently, the install target generated by the CMake script will install librabit.a (Rabit static lib) into the prefix. This is unnecessary, since libxgboost.so already contains all Rabit's object code.

TODO: Refactor Rabit's CMake script.
@hcho3 hcho3 self-assigned this Sep 7, 2020
@trivialfis trivialfis mentioned this issue Sep 8, 2020
Merged
@hcho3
Copy link
Collaborator Author

hcho3 commented Sep 9, 2020

Fixed in #6096

@hcho3 hcho3 closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcho3 hcho3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hcho3