Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] DaskXGBClassifier Early Stopping #5495

Closed
programmylife opened this issue Apr 7, 2020 · 1 comment · Fixed by #6199
Closed

[FEA] DaskXGBClassifier Early Stopping #5495

programmylife opened this issue Apr 7, 2020 · 1 comment · Fixed by #6199

Comments

@programmylife
Copy link

programmylife commented Apr 7, 2020

We (myself and @kylejn27) would like to update our model training to run with DaskXGBClassifier, but it requires early stopping. We would like DaskXGBClassifier to match the spec of XGBClassifier to include early stopping:

DaskXGBClassifier

class DaskXGBClassifier(DaskScikitLearnBase, XGBClassifierBase):
    # pylint: disable=missing-docstring
    _client = None
    def fit(self,
            X,
            y,
            sample_weights=None,
            eval_set=None,
            sample_weight_eval_set=None,
            verbose=True):

XGBClassifier

class XGBClassifier(XGBModel, XGBClassifierBase):
    # pylint: disable=missing-docstring,invalid-name,too-many-instance-attributes
    def __init__(self, objective="binary:logistic", **kwargs):
        super().__init__(objective=objective, **kwargs)
    def fit(self, X, y, sample_weight=None, base_margin=None,
            eval_set=None, eval_metric=None,
            early_stopping_rounds=None, verbose=True, xgb_model=None,
            sample_weight_eval_set=None, callbacks=None):
@trivialfis
Copy link
Member

Yup. Will work on this, I just need to redactor the call back a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants