Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature of Repository.get_shipping_methods #1794

Closed
st8st8 opened this issue Jun 29, 2015 · 3 comments
Closed

Signature of Repository.get_shipping_methods #1794

st8st8 opened this issue Jun 29, 2015 · 3 comments

Comments

@st8st8
Copy link
Contributor

st8st8 commented Jun 29, 2015

Line 447 of paypal/express/views.py calls repo.get_shipping_methods with the signature:

def get_shipping_methods(self, user, basket, shipping_address):
repo = Repository()
return repo.get_shipping_methods(
user, basket, shipping_addr=shipping_address)

But in oscar/apps/shipping/repository.py it's given as:

API

def get_shipping_methods(self, basket, shipping_addr=None, **kwargs):

ie with no "user" argument. I'm not sure which is correct?

@sasha0
Copy link
Member

sasha0 commented Sep 28, 2015

@st8st8 this issue is relevant to django-oscar-paypal application, please report it to corresponding repository issue tracker. Thanks.

@st8st8
Copy link
Contributor Author

st8st8 commented Sep 28, 2015

I did, three weeks before I filed this one, I'm still awaiting a response...
django-oscar/django-oscar-paypal#99

@maiksprenger
Copy link
Member

I'm looking at this issue in django-oscar-paypal now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants