This repository has been archived by the owner on Aug 27, 2018. It is now read-only.
Abstraction of Settings #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures the child will never be able to not have a validate function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Semver Increment Bump: [MAJOR/MINOR/PATCH]
Patch (might be minor depending on the output of this)
Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)
The new settings by @kyranet work wonderfully. People have come to like them very much and I'm pleased with how they turned up. But the way he set it up doesn't let you efficiently edit it to use settings for whatever you want, without having to hard-code a lot of the methods just to change one or two things. This PR will aim to abstract the class more, and differentiate between a "interface" and "Guild Settings". SettingsGateway should be an interface, not the final product. This will allow you to require komada and extend the Gateway for whatever your purposes might be.