Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints? #96

Closed
woodruffw opened this issue Sep 13, 2021 · 1 comment · Fixed by #97
Closed

Type hints? #96

woodruffw opened this issue Sep 13, 2021 · 1 comment · Fixed by #97

Comments

@woodruffw
Copy link
Collaborator

pip-audit is consuming pip-api, and is aiming for 100% MyPy coverage in the process.

pip-api currently doesn't have any type signatures, so we disable our MyPy checking wherever we import pip_api.

Is adding type signatures to the public APIs worth it here? If so, it's something we could dedicate engineering time to.

@di
Copy link
Owner

di commented Sep 13, 2021

I think the public API here is simple enough that this shouldn't be hard to do, and would be beneficial for pip-audit. So yes, I think it's worth doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants