Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clear button and arrow alignment issues #1609

Merged
merged 5 commits into from
Sep 27, 2024
Merged

fix: clear button and arrow alignment issues #1609

merged 5 commits into from
Sep 27, 2024

Conversation

alaa-yahia
Copy link
Member

@alaa-yahia alaa-yahia commented Sep 26, 2024 •
edited by jira bot
Loading

Implements LIBS-654

  • Resolved the alignment issue of the clear button when warning or error icons are displayed.
  • Resolved the issue where the previous and next arrow buttons would shift position based on the length of the month name.

@alaa-yahia alaa-yahia requested a review from a team as a code owner September 26, 2024 01:00
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Sep 26, 2024 •
edited
Loading

🚀 Deployed on https://pr-1609--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify September 26, 2024 01:04 Inactive
kabaros
kabaros approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@kabaros kabaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected👌🏿

@dhis2-bot dhis2-bot temporarily deployed to netlify September 26, 2024 14:50 Inactive
@alaa-yahia alaa-yahia force-pushed the LIBS-654-fix-clear-button-issue-in-multi-calendar-component branch from 3eedecb to 7de5cdc Compare September 26, 2024 19:36
@dhis2-bot dhis2-bot temporarily deployed to netlify September 26, 2024 19:41 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify September 26, 2024 19:55 Inactive
@alaa-yahia alaa-yahia merged commit ba0b657 into alpha Sep 27, 2024
16 checks passed
@alaa-yahia alaa-yahia deleted the LIBS-654-fix-clear-button-issue-in-multi-calendar-component branch September 27, 2024 07:45
dhis2-bot added a commit that referenced this pull request Sep 27, 2024
@dhis2-bot
chore(release): cut 9.12.0-alpha.4 [skip release]
2cfaea1 
# [9.12.0-alpha.4](v9.12.0-alpha.3...v9.12.0-alpha.4) (2024-09-27)

### Bug Fixes

* clear button and arrow alignment issues ([#1609](#1609)) ([ba0b657](ba0b657))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.12.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabaros kabaros kabaros approved these changes

Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alaa-yahia @dhis2-bot @kabaros