Switch Badger Options to reasonable settings for p and w directories. #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
…dgraph-io#2605) * Pick Badger Options which use LSM tree a bit more, so it would colocate values below 1KB with the keys. This allows easier reclamation of value log space, reducing the size of data consumption by Dgraph. A test run of 21M data set, resulted in 3.3GB, compared to 5.7GB with previous settings. The number of value log files also decreased considerably due to easier cleanup. * This change removes the need to expose `--badger.options=ssd,hdd` options. We've chosen a middle ground setting, which should work in most cases. * Remove the none option, which is confusing. * Output the options used to open WAL as well. * Pull in Badger updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is