Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inSnapshot logic #2480

Merged
merged 5 commits into from
Jul 10, 2018
Merged

Remove inSnapshot logic #2480

merged 5 commits into from
Jul 10, 2018

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Jul 10, 2018

  • Remove local Oracle map commit and abort tracking. Oracle only gets to know about it after the commits or aborts have already been applied to the posting lists.
  • Simplify OracleDelta by using TxnStatus, instead of map. This allows txns statuses to be sorted by CommitTs, which adds determinism to our codebase.

This change is Reviewable

@manishrjain manishrjain changed the title Switch to a list of Txn statuses, which can be sorted by CommitTs Remove inSnapshot logic Jul 10, 2018
@manishrjain manishrjain merged commit d676abf into master Jul 10, 2018
@manishrjain manishrjain deleted the mrjn/oracle-txnstatus branch July 10, 2018 05:01
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
- Remove local Oracle map commit and abort tracking. Oracle only gets to know about it after the commits or aborts have already been applied to the posting lists.
- Simplify OracleDelta by using TxnStatus, instead of a map. This allows transaction statuses to be sorted by CommitTs, which adds determinism to our codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant