Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rgl.* calls to *3d calls. #48

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Conversation

dmurdoch
Copy link
Contributor

Some upcoming changes to the rgl package will require changes to
fsbrain. I will be deprecating a number of rgl.* function calls.
You can read about the issues here:

  https://dmurdoch.github.io/rgl/articles/deprecation.html

I have made the required changes to fsbrain in the attached patches. These
changes should work with both old and new rgl versions.

I doubt if these will have any effect on #46, but it might be worth trying them out. As I commented there, the sample code dies very early on my system before any graphing, so it might be completely unrelated to rgl.

@dfsp-spirit
Copy link
Owner

dfsp-spirit commented Jan 12, 2023

Thanks a lot for the heads-up and PR, I will check it out.

@dfsp-spirit dfsp-spirit merged commit f6ab0aa into dfsp-spirit:master Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants