Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectors that don't support refresh tokens shouldn't return one instead of erroring #871

Closed
ericchiang opened this issue Mar 23, 2017 · 0 comments · Fixed by #872
Closed
Assignees

Comments

@ericchiang
Copy link
Contributor

If a connector doesn't implement connector.RefreshConnector it should silently not return a refresh token when offline_access is requested instead of erroring out, like our current SAML connector.

For backwards compatibility we'll have to make the OIDC connector implement this method, so it continues to support refresh tokens, despite not being able to refresh the users identity (#863).

// Refresh is implemented for backwards compatibility, even though it's a no-op.
func (o *oidcConnector) Refresh(ctx context.Context, s connector.Scopes, identity connector.Identity) (connector.Identity, error) {
    return identity, nil
}

cc @rithujohn191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants