Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍀 Proposal: dtm show status Improvement #557

Closed
IronCore864 opened this issue May 20, 2022 · 3 comments
Closed

🍀 Proposal: dtm show status Improvement #557

IronCore864 opened this issue May 20, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@IronCore864
Copy link
Member

IronCore864 commented May 20, 2022

What would you like to add? Why is this needed?

Background

Currently, dtm supports a show status subcommand:

tiexin@mbp ~/work/stream $ ./dtm show --help
Show is used to print some useful information.
Examples:
  dtm show config --plugin=A-PLUGIN-NAME
  dtm show status --plugin=A-PLUGIN-NAME --name=A-PLUGIN-INSTANCE-NAME
  dtm show status -p=A-PLUGIN-NAME -n=A-PLUGIN-INSTANCE-NAME 

As we can see, if we run dtm show status -p=A-PLUGIN-NAME -n=A-PLUGIN-INSTANCE-NAME, the "status" of that plugin and that instance will be printed.

Improvement 1

We have changed our config file. Now the parameters for this command should be "plugin" and "instanceID", so "-p=A-PLUGIN-NAME -n=A-PLUGIN-INSTANCE-NAME" isn't precise any longer.

We suggest "-p=A-PLUGIN-NAME -i=INSTANCE-ID".

Improvement 2

Would be nice if we can dtm show status --all or dtm show status -a so that the status of all instances of all plugins are printed out.

@IronCore864 IronCore864 added the good first issue Good for newcomers label May 20, 2022
@24sama
Copy link
Contributor

24sama commented May 20, 2022

/assign

@24sama
Copy link
Contributor

24sama commented May 20, 2022

Hi @IronCore864 @daniel-hutao
Please assign this issue to me, I can try to fix it.

@daniel-hutao
Copy link
Member

/assign @24sama Happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants