Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to lower-dash-case in file names across all packages #84

Open
zeihlis opened this issue Oct 17, 2018 · 9 comments
Open

Migrate to lower-dash-case in file names across all packages #84

zeihlis opened this issue Oct 17, 2018 · 9 comments

Comments

@zeihlis
Copy link
Contributor

zeihlis commented Oct 17, 2018

Lower case in path input/Input.tsx can cause build fail on CI(Teamcity for example) sometimes because it lets Windows to neglect mistaken font case and also it doesn't look like consistent naming of platform components.

  • check all packages
  • force casing with a tslint/eslint rule (depends on the package used)
@raveclassic
Copy link
Contributor

raveclassic commented Oct 17, 2018

General recommendation is to use lower-dash-case for all files

@sutarmin
Copy link
Contributor

I suggest creating codemod. It will make a migration to the new version of dx-platform easier.

@mankdev
Copy link
Contributor

mankdev commented Oct 28, 2018

I suggest creating codemod. It will make a migration to the new version of dx-platform easier.

hmmmm

may be there are some node library? Python seems strange dependency for such operations.

@sutarmin
Copy link
Contributor

I don't find python strage for such operations. But we with @zeihlis disscussed offline that maybe there is no need for complex thing like codemod, we can just write find-replace script in plain node and publish it as gist or something :)

@raveclassic
Copy link
Contributor

closing in favor of #145

@raveclassic
Copy link
Contributor

After all decided to do this separately after #145

@raveclassic raveclassic reopened this Sep 5, 2019
@raveclassic raveclassic changed the title Input component path sometimes causing build fail Migrate to lower-dash-case in file names across all packages Sep 5, 2019
@raveclassic raveclassic added this to the 1.0 milestone Sep 5, 2019
@sutarmin
Copy link
Contributor

sutarmin commented Sep 5, 2019

After all decided to do this separately after #145

I think it makes sense to do that simultaneously with #145, why not?

@raveclassic
Copy link
Contributor

@sutarmin #145 is on hold until it's clear how new "design system" project will impact current platform. Perhaps wasting resource on migration of existing kit which may become incompatible with a new one is pointless.

@raveclassic
Copy link
Contributor

Taking that into account I should note that it may be possible to apply these changes before #145 . That's why it's separate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants