-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue SET_INTERFACE even if alt=0 #14
Comments
Hi @smunaut, thanks for bringing this up. At a glance, it looks like
That should be pretty straightforward to implement here, though I'll have to do some testing to make sure it doesn't break DFU for any of the devices I have lying around. Looking through the dfu-util bug tracker, it seems like the |
So a SET_INTERFACE on a interface with a single alt setting is allowed to fail, so if it does, you should ignore it. It's perfectly valid for a device to STALL on that. |
It makes sense that a device might STALL the request, but from the |
Hi @smunaut, I've started #15 to try to address this. From testing on Windows and Linux, it seems that on Windows the OS automagically sends the |
I tested on the test website linked in the PR and this worked for me here (on linux). |
As a side note, it's also be nice to be able to skip the reset() at the end of download phase. Devices with multiple interfaces can be because you have multiple part the firmware or multiple MCU etc ... that need to be updated together / stay in sync and so you download fw #0, then fw #1 and then only you reset. |
Hmm, I see, I guess I could refactor |
Some devices with several alt settings for the DFU interface expect a call to SET_INTERFACE even if the alt settings you want to use is the default 0 one.
dfu-util
issues SET_INTERFACE all the time to deal with that, but seems the web impl doesn.The text was updated successfully, but these errors were encountered: