Add a lock reason with "resolved" #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzoo, looks great, the change has been deployed, thanks a lot! |
|
Awesome thanks! will try to merge babel/babel#7839 next! |
|
Also this was an obvious answer too https://twitter.com/pshrmn/status/991093233475293184 maybe we should add an optional label in place of a comment (like |
|
Ok made #4 if that is useful |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref babel/babel#7839 (comment)
For the preview, I looked at https://github.com/octokit/rest.js#api-previews and you can already just pass a header (thanks @gr2m)
resolvedseems to make the most since here so I just hardcoded it. Although maybe we can suggest a new one for this use-case. Feel free to modify this PR if needed