Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise the singular and plural forms of variables #203

Closed
kwunyeung opened this issue Jun 27, 2020 · 5 comments · Fixed by #241
Closed

Revise the singular and plural forms of variables #203

kwunyeung opened this issue Jun 27, 2020 · 5 comments · Fixed by #241
Assignees
@leobragaz
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add x/posts Post module
Milestone
v0.10.0

Comments

@kwunyeung
Copy link
Contributor

The variables using for media is not correct and may mislead in development.

desmos/x/posts/internal/types/models/common/post_media.go

Line 14 in ed22aae

type PostMedia struct {

Media is the plural form of the word Medium. Should we change the type to PostMedium and the variable of the slice PostMedia instead of PostMedias, and the object in the msg type Media instead of Medias?
@leobragaz
Copy link
Contributor

Yes you are right, I'm okay with this. We could apply this in 0.9.0

@leobragaz leobragaz self-assigned this Jun 29, 2020
@leobragaz leobragaz added this to the v0.9.0 milestone Jun 29, 2020
@leobragaz leobragaz added kind/enhancement Enhance an already existing feature; no "New feature" to add x/posts Post module labels Jun 29, 2020
@RiccardoM RiccardoM modified the milestones: v0.9.0, v0.9.1 Jul 8, 2020
@RiccardoM
Copy link
Contributor

Probably, what we could do is rename the entire Media thing to be Attachment (with plural Attachments) instead. This would also make it more clear.

What do you think @kwunyeung @bragaz?

@kwunyeung
Copy link
Contributor Author

@RiccardoM good idea! 🎉

@leobragaz
Copy link
Contributor

@RiccardoM I'll take care of this ok?

@RiccardoM
Copy link
Contributor

@RiccardoM I'll take care of this ok?

Sure

@RiccardoM RiccardoM modified the milestones: v0.9.1, v0.10.0 Jul 14, 2020
@leobragaz leobragaz mentioned this issue Jul 21, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leobragaz leobragaz

Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add x/posts Post module
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

Revise the singular and plural forms of variables desmos-labs/desmos
3 participants
@kwunyeung @RiccardoM @leobragaz