Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new aria-braille* properties #3899

Closed
pkra opened this issue Jan 27, 2023 · 3 comments · Fixed by #3956
Closed

support new aria-braille* properties #3899

pkra opened this issue Jan 27, 2023 · 3 comments · Fixed by #3956
Labels
feat New feature or enhancement pr A pr has been created for the issue standards Issues in the ARIA standards objects (lib/standards) wai-aria
Milestone

Comments

@pkra
Copy link

pkra commented Jan 27, 2023

Product

axe-core

Feature Description

The new properties aria-braillelabel and aria-brailleroledescription are on track to be added to ARIA 1.3, see w3c/aria#1331 for additional details.

Basic support (i.e., not flagging them as invalid) would be great to have in time for 1.3.

@pkra pkra added feat New feature or enhancement ungroomed Ticket needs a maintainer to prioritize and label labels Jan 27, 2023
@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jan 27, 2023

Thanks for raising this. Since there's no support for this yet, the benefit of this will be minimal. I'm curious to see whether AT vendors even end up implementing this at all, since there's a high potential for problems with these.

Regarding axe-core though, since these enhance an existing label / description, I see no reason why we couldn't add them, and so maybe encourage some early adoption. That seems fairly harmless to me. I do think we should put some guard rails in place though. It has kind of the same problem aria-description has. When used as intended, the lack of support isn't an issue. But devs may end up using them instead of labels, or on elements where they really don't belong. I think we're going to need to discoruage that.

I'm inclined to add these, but then add a new rule that ensures these are only used on elements with a role and an accessible name. I think that would work for aria-description too. See: #3121

@WilcoFiers WilcoFiers added wai-aria standards Issues in the ARIA standards objects (lib/standards) and removed ungroomed Ticket needs a maintainer to prioritize and label labels Jan 27, 2023
@WilcoFiers WilcoFiers added this to the Axe-core 4.7 milestone Jan 27, 2023
@pkra
Copy link
Author

pkra commented Jan 27, 2023

Thanks for the response, @WilcoFiers!

Since there's no support for this yet, the benefit of this will be minimal.

Just for those who don't want to look up the ARIA 1.3 milestone: all major browsers now have support. On the AT side, Orca supports them already. Since this idea came out of a workshop a few years ago where both NVDA and JAWS developers were involved, I'm hopeful they'll get around to it. Apple seems open to the properties as well (e.g., Safari already includes the webkit patches).

I see no reason why we couldn't add them, and so maybe encourage some early adoption. That seems fairly harmless to me.

That would be great!

I do think we should put some guard rails in place though. It has kind of the same problem aria-description has.

Right. A lot of wordsmithing went into warnings in the spec language to generally discourage their use. I'd say the properties are for extraordinary use cases where authors have highly specialized braille requirements (and knowledge), e.g., in education.

I think it would not hurt at all if tools like axe would give similarly strong warnings.

@padmavemulapati
Copy link

padmavemulapati commented Mar 28, 2023

Validated with the latest axe-core-develop branch code base,
aria-valid-attr is now allowing the attributes aria-braillelabel and aria-brailleroledescription with these two attributes its passing.

Image

where as in the earlier versions if we keep - aria-braillelabel, aria-brailleroledescription and aria-description attributess
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or enhancement pr A pr has been created for the issue standards Issues in the ARIA standards objects (lib/standards) wai-aria
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants