Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): return this rather than the class #360

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

WilcoFiers
Copy link
Contributor

These need to return this, so that the classes can properly be extended. If we didn't return this, the following would be a problem:

class DevToolsWebdriverIO extends AxeBuilder {
  foo() {}
}
// foo does not exist on type AxeBuilder
new DevToolsWebdriverIO().include('foo').foo();

@WilcoFiers WilcoFiers merged commit 7999891 into develop Sep 9, 2021
@WilcoFiers WilcoFiers deleted the return-this branch September 9, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants