Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped updates using update-types result in error "undefined method `segments'" #7978

Closed
1 task done
lorengordon opened this issue Sep 6, 2023 · 2 comments · Fixed by #8124
Closed
1 task done
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR T: bug 🐞 Something isn't working

Comments

@lorengordon
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

docker, github-actions

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

plus3it/spel-repo-builder@90c4017

Updated dependency

No response

What you expected to see, versus what you actually saw

Expected Dependabot to create a grouped update for only patch and minor versions. Instead, it generated an error:

updater | 2023/09/05 15:29:04 ERROR <job_718292262> undefined method `segments' for "0.24.11":String
updater | 
updater |           major: version.segments[0] || 0,
updater |                         ^^^^^^^^^
updater | 2023/09/05 15:29:04 ERROR <job_718292262> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:233:in `semver_segments'
updater | 2023/09/05 15:29:04 ERROR <job_718292262> /home/dependabot/dependabot-updater/lib/dependabot/updater/group_update_creation.rb:221:in `semver_rules_allow_grouping?'

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

See other references claiming the same problem:

@jurre
Copy link
Member

jurre commented Sep 6, 2023

This seems very similar to #7961, very likely to be the same root cause, but I'll keep both open since in that case it's nil, and here it's a string

@jakecoffman jakecoffman added the F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR label Sep 28, 2023
@jakecoffman
Copy link
Member

I think I fixed the issue if you want to try again and let us know how it goes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR T: bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants