Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse GITHUB_TOKEN and GHCR_CREDS down to a single variable. #182

Open
partkyle opened this issue Aug 20, 2024 · 1 comment · May be fixed by #256
Open

Collapse GITHUB_TOKEN and GHCR_CREDS down to a single variable. #182

partkyle opened this issue Aug 20, 2024 · 1 comment · May be fixed by #256
Assignees

Comments

@partkyle
Copy link
Contributor

          We would need only one of them. We can take care of this later.

Originally posted by @naveensrinivasan in #168 (comment)

@marshall007
Copy link
Contributor

It turns out we need neither of them! I created #256 which:

  1. removes the dependency on the GH API for fetching package versions
  2. fetches tags directly from the registry and uses hashicorp/go-version to sort them semantically
  3. uses github.com/google/go-containerregistry/pkg/authn to source registry credentials from standard locations instead of a custom --registry-creds CLI argument

@marshall007 marshall007 self-assigned this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants