feat: add support for Multikey #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #304 BREAKING CHANGE: The return types have changed for of `extractPublicKeyBytes()` and `multibaseToBytes()` from Uint8Arrays to Objects containing the `keyBytes: Uint8Array` and a decoded or inferred `keyType: string | undefined`
mirceanis
commented
Jan 17, 2024
Comment on lines
+296
to
+298
| const possibleCodec: string | undefined = | ||
| Object.entries(supportedCodecs).filter(([, code]) => code === codec)?.[0][0] ?? '' | ||
| return { keyBytes: bytes.slice(length), keyType: CODEC_TO_KEY_TYPE[possibleCodec as KNOWN_CODECS] } |
There was a problem hiding this comment.
This is the most relevant change
nickreynolds
approved these changes
Jan 17, 2024
uport-automation-bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
# [8.0.0](7.4.7...8.0.0) (2024-01-18) ### Features * add support for Multikey ([#305](#305)) ([20bbc3e](20bbc3e)), closes [#304](#304) ### BREAKING CHANGES * The return types have changed for of `extractPublicKeyBytes()` and `multibaseToBytes()` from Uint8Arrays to Objects containing the `keyBytes: Uint8Array` and a decoded or inferred `keyType: string | undefined`
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #304
This PR adds support for
Multikeyverification methods, both for signature verification and for key agreement.I also added a few internal mappings for known key types, verification methods, algorithms and multiformat codecs.
BREAKING CHANGE: The return types have changed for of
extractPublicKeyBytes()andmultibaseToBytes()from Uint8Arrays to Objects containing thekeyBytes: Uint8Arrayand a decoded or inferredkeyType: string | undefinedMerging this PR should trigger a major version bump