Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isPositive returns true for zero #100

Closed
imirkin opened this issue Jul 7, 2021 · 0 comments · May be fixed by NOUIY/cloud#3809 or NOUIY/cloud#4102
Closed

isPositive returns true for zero #100

imirkin opened this issue Jul 7, 2021 · 0 comments · May be fixed by NOUIY/cloud#3809 or NOUIY/cloud#4102
Labels
help wanted

Comments

@imirkin
Copy link

imirkin commented Jul 7, 2021

Long.ZERO.isPositive() returns true. This is not the usual meaning of "is positive". Perhaps update the documentation to indicate non-negative? (Since it's probably not feasible to change the API to return false for zero.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade long from 5.2.0 to 5.2.3 NOUIY/cloud
[Snyk] Upgrade: long, next NOUIY/cloud
2 participants
@imirkin @dcodeIO