Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature requests for DCO integration? #8

Closed
bkeepers opened this issue Mar 25, 2017 · 4 comments
Closed

Feature requests for DCO integration? #8

bkeepers opened this issue Mar 25, 2017 · 4 comments

Comments

@bkeepers
Copy link
Contributor

Currently, this GitHub Integration will check commits in a Pull Requests to verify that all of them have the DCO sign-off. See #2 for a demo. As the README documents, you can use require statuses to require that the DCO check passes before allowing a pull request to be merged.

What other features are desired for DCO integration?

cc @mkdolan @caniszczyk

@bkeepers
Copy link
Contributor Author

By the way, feel free to try this out on own project.

@bkeepers
Copy link
Contributor Author

@mikeal said:

the main feature I would want would be "comment in the PR with instructions on how to add sign-off-by by default"

@mkdolan
Copy link

mkdolan commented Apr 1, 2017

@bkeepers awesome! Is it possible to also require signed commits with the sign-off on?

@bkeepers
Copy link
Contributor Author

bkeepers commented Apr 2, 2017

@bkeepers awesome! Is it possible to also require signed commits with the sign-off on?

@mkdolan you mean GPG signed? That's a great suggestion. There is a commit signature verification API, so it should be pretty easy to add an option that commits also be GPG signed.

Would you expect that to be the default for this integration, or is it common for projects to not require GPG signatures?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants