Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseMixin.filterPrinter defaults to dc.printers.filters plural, not singular #1228

Closed
gordonwoodhull opened this issue Nov 20, 2016 · 0 comments
Closed

baseMixin.filterPrinter defaults to dc.printers.filters plural, not singular #1228

gordonwoodhull opened this issue Nov 20, 2016 · 0 comments
Labels
docs
Milestone
non-breaking

Comments

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Nov 20, 2016 •
edited
Loading

The text is correct, but it references the wrong class.

By default dc charts use a default filter printer dc.printers.filter that provides simple printing support for both single value and ranged filters.

That's dc.printers.filters; also below in the table.

Also it should link to the documentation for the class. And it should provide an example, for the function signature.
@gordonwoodhull gordonwoodhull changed the title filterPrinter uses dc.printers.filters plural, not singular baseMixin.filterPrinter uses dc.printers.filters plural, not singular Nov 20, 2016
@gordonwoodhull gordonwoodhull changed the title baseMixin.filterPrinter uses dc.printers.filters plural, not singular baseMixin.filterPrinter defaults to dc.printers.filters plural, not singular Nov 20, 2016
@gordonwoodhull gordonwoodhull modified the milestone: v2.0 Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
non-breaking
Development

No branches or pull requests
1 participant
@gordonwoodhull