Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-864] Make changes necessary to support dbt-core switch away from hologram #591

Closed
gshank opened this issue Aug 30, 2023 · 0 comments
Closed

[ADAP-864] Make changes necessary to support dbt-core switch away from hologram #591

gshank opened this issue Aug 30, 2023 · 0 comments

Comments

@gshank
Copy link
Contributor

gshank commented Aug 30, 2023

Description

With dbt-labs/dbt-core#8437 we switched to using mashumaro instead of hologram for jsonschema generation. This caused breakage in some code pulling in FieldEncoder from hologram, which looks dead.

Solution

Remove the dead code.
@github-actions github-actions bot changed the title Make changes necessary to support dbt-core switch away from hologram [ADAP-864] Make changes necessary to support dbt-core switch away from hologram Aug 30, 2023
@mikealfare mikealfare closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gshank @mikealfare