Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics for dbt.com in addition to getdbt #430

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

b-per
Copy link
Contributor

@b-per b-per commented Jun 15, 2023

Description

Allows Snowplow analytics for non US MT

Checklist

@cla-bot cla-bot bot added the cla:yes label Jun 15, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

@ericalouie ericalouie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big thumbs up 👍

@b-per
Copy link
Contributor Author

b-per commented Nov 13, 2023

@graciegoheen sorry for the ping here, but do you know if it is OK to merge this knowing it's been approved by Ric? And what would be the next steps to get it included in dbt-core

@graciegoheen graciegoheen added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Nov 13, 2023
@graciegoheen
Copy link

Thanks for bumping @b-per - I just added our ready_for_review label, which will queue it up for review from our team!

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.
I don't have a good way to validate this so will merge once we get confirmation from @b-per

@ChenyuLInx
Copy link
Contributor

Confirmed it do not have bad side effect from @b-per

@ChenyuLInx ChenyuLInx merged commit e9cbdad into main Nov 28, 2023
3 checks passed
@ChenyuLInx ChenyuLInx deleted the add-analytics-dbt branch November 28, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants