Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3447] [dbt/artifacts] [spike+] Move RunResultsArtifact to dbt/artifacts directory #9200

Closed
1 task done
Tracked by #9099
MichelleArk opened this issue Dec 4, 2023 · 0 comments · Fixed by #9350
Closed
1 task done
Tracked by #9099
Assignees

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Dec 4, 2023

Housekeeping

  • I am a maintainer of dbt-core

Short description

We'd like to begin moving our ArtifactMixin subclasses upstream of other core modules in order to decouple core's internal functional concerns from external data interfaces. Once the initial structure is laid down in #9193, let's continue this exercise by spiking moving RunResultsArtifact to dbt/artifact. The upstream node classes should be split into data & functional interfaces, defined in dbt/artifacts in dbt/core respectively. Additionally, any inheritance hierarchy for node attributes should be flattened as part of this spike.

Acceptance criteria

A spike report that highlights any potential approaches and their tradeoffs, as well as a summary of any potential blockers encountered.

Impact to Other Teams

N/A - should be a refactor.

Will backports be required?

nope

Context

Should be done after #9193 to avoid duplicating foundational setup work.

@github-actions github-actions bot changed the title [dbt/artifacts] [spike+] Move RunResultsArtifact to dbt/artifacts directry [CT-3447] [dbt/artifacts] [spike+] Move RunResultsArtifact to dbt/artifacts directry Dec 4, 2023
@MichelleArk MichelleArk changed the title [CT-3447] [dbt/artifacts] [spike+] Move RunResultsArtifact to dbt/artifacts directry [CT-3447] [dbt/artifacts] [spike+] Move RunResultsArtifact to dbt/artifacts directory Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants