Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-3103] [BACKPORT] [Bug] dbt show adding decimal places to non-decimal values #8611

Closed
1 task done
emmyoop opened this issue Sep 11, 2023 · 2 comments
Closed
1 task done

[CT-3103] [BACKPORT] [Bug] dbt show adding decimal places to non-decimal values #8611

emmyoop opened this issue Sep 11, 2023 · 2 comments
Assignees
@emmyoop
Labels
backport 1.6.latest Impact: Adapters user docs [docs.getdbt.com] Needs better documentation

Comments

@emmyoop
Copy link
Member

emmyoop commented Sep 11, 2023

Housekeeping

  • I am a maintainer of dbt-core

Short description

Backport #8153 to 1.6.latest

This will break adapter tests and needs to be coordinated with them

Acceptance criteria

Change is backported and all adapter tests run successfully

Impact to Other Teams

Some tests in adapters break as a result of this change. Adapter functionality itself does not break.

Will backports be required?

This ticket is specifically for the 1.6 backport. The change is already on main.

Context

No response
@emmyoop emmyoop added user docs [docs.getdbt.com] Needs better documentation backport 1.6.latest Impact: Adapters labels Sep 11, 2023
@emmyoop emmyoop self-assigned this Sep 11, 2023
@github-actions github-actions bot changed the title [BACKPORT] [Bug] dbt show adding decimal places to non-decimal values [CT-3103] [BACKPORT] [Bug] dbt show adding decimal places to non-decimal values Sep 11, 2023
@emmyoop
Copy link
Member Author

emmyoop commented Sep 11, 2023

Currently blocked on capacity from adapters team.

@emmyoop emmyoop mentioned this issue Sep 11, 2023
Merged
@emmyoop
Copy link
Member Author

emmyoop commented Sep 13, 2023

Completed by #8619

@emmyoop emmyoop closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmyoop emmyoop

Labels
backport 1.6.latest Impact: Adapters user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emmyoop