You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update SQLQueryStatus to take in the full adapter_response object, and node name. Today we stringify the adapter reponse first making it much harder to consume. Special attention will have to be paid to serialization since each warehouse will be putting different values into their own responses. Using examples from today's warehouses for inputs to serialization tests is a good idea. The name of the currently running node is accessible via the "jinja god context" (TODO: link example of how to access the jinja god context) (TODO: adapter.execute is called in other places too. We should add log lines there too. Link exact lines here.)
In my words:
I would like to see CodeExecutionStatus include the full AdapterResponse object (serialized to dict), rather than just the stringified message.
We also already include adapter_response in RunResult, but not every query execution actually yields a RunResult, only the last query for a given node.
The text was updated successfully, but these errors were encountered:
github-actionsbot
changed the title
Consolidate code execution result events, include adapter_response
[CT-1904] Consolidate code execution result events, include adapter_response
Jan 25, 2023
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.
Consolidate event types
We added
CodeExecution
,CodeExecutionStatus
, and thelog_code_execution
decorator when we added Python models:dbt-core/core/dbt/adapters/base/impl.py
Lines 125 to 143 in eb200b4
We should replace/consolidate
SQLQuery
+SQLQueryStatus
to use those instead.Include
adapter_response
for all query resultscopying this part from #5325
In my words:
CodeExecutionStatus
include the full AdapterResponse object (serialized to dict), rather than just the stringified message.The text was updated successfully, but these errors were encountered: