Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1088] packing a dbt project into kedro starter #5718

Closed
3 tasks done
Kurdzik opened this issue Aug 26, 2022 · 4 comments
Closed
3 tasks done

[CT-1088] packing a dbt project into kedro starter #5718

Kurdzik opened this issue Aug 26, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Kurdzik
Copy link

Kurdzik commented Aug 26, 2022

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

I would like to integrate dbt project into kedro starter.

Right now whenever i do that kedro project can't be created because both kedro and dbt make use of Jinja functions,

Kedro uses cookiecutter under the hood to clone repo and then replace all existing jinja functions with custom data.
It fails to generate a project because it also tries to replace jinja functions located inside dbt project

And all solutions i've found on the internet about putting directory path to cookiecutter.json so that it will not take some folders into consideration, have failed

Describe alternatives you've considered

Right now we have kedro starters on one repo and dbt projects on another.

Then use shell script located inside kedro project in order to pull dbt project and initiate it (create profiles.yml etc.)

Who will this benefit?

We are working on set of different starters to automate some repetitive tasks, given data in the same format.

Since making transformations directly on a database is much quicker than downloading data, transforming it and then uploading it again, we thought about using dbt for that purpose.

And then running kedro on newly created tables

Are you interested in contributing this feature?

yes

Anything else?

No response

@Kurdzik Kurdzik added enhancement New feature or request triage labels Aug 26, 2022
@github-actions github-actions bot changed the title packing a dbt project into kedro starter [CT-1088] packing a dbt project into kedro starter Aug 26, 2022
@lostmygithubaccount
Copy link
Contributor

lostmygithubaccount commented Aug 26, 2022

@Kurdzik thanks for opening! do you have an idea of how to implement this feature? we'd be happy to help you along to contribute this, but it's likely not something we'll prioritize ourselves

kedro also looks very interesting, I would be curious to learn more about how you & others are planning to use it with dbt!

edit as I'm looking at things assigned to me: is the issue the version of Jinja isn't compatible? I believe this has been bumped in 1.3, so might fix itself then. see #4748 and #5465 if that's the issue

@lostmygithubaccount
Copy link
Contributor

assigning to myself to not lose track of this one, not sure what's going on with the bot and labels there

@Kurdzik
Copy link
Author

Kurdzik commented Sep 20, 2022

i did some more testing and passing path to dbt project inside "_copy_without_render " argument to cookiecutter.json (part of a kedro project), will prevent cookiecutter from replacing jinja functions which are inside a dbt project. And thus will enable for dbt project to exist inside a kedro project, so problem solved :)

@lostmygithubaccount
Copy link
Contributor

@Kurdzik great to hear! I'm curious to learn more if there are any pointers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants