Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-551] Extra scrubbing for git clone exceptions #5151

Closed
jtcohen6 opened this issue Apr 25, 2022 · 0 comments · Fixed by #5152
Closed

[CT-551] Extra scrubbing for git clone exceptions #5151

jtcohen6 opened this issue Apr 25, 2022 · 0 comments · Fixed by #5152
Labels
bug Something isn't working deps dbt's package manager
Milestone

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Apr 25, 2022

Despite the fix in #4507, we're still seeing raw secrets in some exceptions, especially when dbt-core is invoked as a Python module.

  • We should look to scrub the contents of CommandResultError (cmd, stdout, stderr), since this can appear in exception tracebacks
  • We might want to add a few duplicative layers? Better safe than sorry?

raise dbt.exceptions.CommandResultError(cwd, cmd, proc.returncode, out, err)

def _raise_git_cloning_error(repo, revision, error):
stderr = error.stderr.decode("utf-8").strip()

@jtcohen6 jtcohen6 added the deps dbt's package manager label Apr 25, 2022
@jtcohen6 jtcohen6 added this to the v1.0.6 milestone Apr 25, 2022
@jtcohen6 jtcohen6 self-assigned this Apr 25, 2022
@github-actions github-actions bot changed the title Extra scrubbing for git clone exceptions [CT-551] Extra scrubbing for git clone exceptions Apr 25, 2022
@jtcohen6 jtcohen6 mentioned this issue Apr 25, 2022
6 tasks
@jtcohen6 jtcohen6 added the bug Something isn't working label Apr 26, 2022
@jtcohen6 jtcohen6 removed their assignment Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deps dbt's package manager
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant