Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-341] Small changie fixes #4848

Closed
emmyoop opened this issue Mar 9, 2022 · 0 comments · Fixed by #4857
Closed

[CT-341] Small changie fixes #4848

emmyoop opened this issue Mar 9, 2022 · 0 comments · Fixed by #4857
Labels
bug Something isn't working

Comments

@emmyoop
Copy link
Member

emmyoop commented Mar 9, 2022

changie has been released but a few small tweaks have come up.

  1. Don't repost the PR comment that a changelog entry to required for every commit pushed to the PR. Look into using https://github.com/marketplace/actions/find-comment
  2. The link in that comment is wrong. It is also wrong in the header file. It should point to https://github.com/dbt-labs/dbt-core/blob/main/CONTRIBUTING.md#adding-changelog-entry
    body: "Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see [the contributing guide](CONTRIBUTING.md)."

    - Do not edit this file directly. This file is auto-generated using [changie](https://github.com/miniscruff/changie). For details on how to document a change, see [the contributing guide](CONTRIBUTING.md)
@emmyoop emmyoop added the bug Something isn't working label Mar 9, 2022
@github-actions github-actions bot changed the title Small changie fixes [CT-341] Small changie fixes Mar 9, 2022
@emmyoop emmyoop mentioned this issue Mar 11, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant