Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcrypto does not break macOS build #182

Open
janstary opened this issue May 28, 2024 · 1 comment
Open

libcrypto does not break macOS build #182

janstary opened this issue May 28, 2024 · 1 comment

Comments

@janstary
Copy link
Contributor

This is 5.6.0 on a macOS 14.5. Running ./configure --help says

--enable-libcrypto      use libcrypto MD5 if available (breaks Mac build)

but running ./configure --enable-libcrypto makes it build just fine.

@dbry
Copy link
Owner

dbry commented Jun 17, 2024

Hi Jan, sorry for the delayed response!

At one point this was definitely broken because the include file openssl/md5.h seemed to be missing on Mac. I don't know if that got added at some point or the include path wasn't being set correctly, but interesting that it's no longer broken.

However the other reason I decided to ditch this is it was adding complexity with virtually no benefit. I never saw the MD5 calculation improve more than 5% using the library, and even in the worst case the MD5 calculation is only a small portion of the total time. The tradeoff didn't seem worth it, especially since MD5 is user-enabled.

The less I have to worrry about going forward the better.... 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants