From c2ba765cf49fa3d0a76e96f7fd9dbc739815f5f2 Mon Sep 17 00:00:00 2001 From: A-Baji Date: Wed, 28 Sep 2022 14:26:20 -0500 Subject: [PATCH 1/4] split comp type on colon to allow POST request overriding --- pharus/dynamic_api_gen.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pharus/dynamic_api_gen.py b/pharus/dynamic_api_gen.py index e47080b..2d02b88 100644 --- a/pharus/dynamic_api_gen.py +++ b/pharus/dynamic_api_gen.py @@ -126,14 +126,16 @@ def {method_name}() -> dict: f.write( (active_route_template).format( route=comp["route"], - rest_verb="POST" if comp["type"] == "form" else "GET", + rest_verb="POST" + if comp["type"].split(":")[0] == "form" + else "GET", method_name=comp["route"].replace("/", ""), component_type=comp["type"], component_name=comp_name, component=json.dumps(comp), static_config=static_config, payload="payload=request.get_json()" - if comp["type"] == "form" + if comp["type"].split(":")[0] == "form" else "", method_name_type="dj_query_route", ) From bebc4c70e6a020eacc9c1ca7c28ba997d348390a Mon Sep 17 00:00:00 2001 From: A-Baji Date: Wed, 28 Sep 2022 14:31:28 -0500 Subject: [PATCH 2/4] update ver and changelog --- CHANGELOG.md | 8 ++++++++ pharus/version.py | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3a7161a..4451f8a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,14 @@ Observes [Semantic Versioning](https://semver.org/spec/v2.0.0.html) standard and [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) convention. +## [0.5.2] - TBD + +### Fixed + +- Component type check condition to allow form POST route overriding + +### Added + ## [0.5.1] - 2022-09-27 ### Added diff --git a/pharus/version.py b/pharus/version.py index c367fa9..ef66e76 100644 --- a/pharus/version.py +++ b/pharus/version.py @@ -1,2 +1,2 @@ """Package metadata.""" -__version__ = "0.5.1" +__version__ = "0.5.2" From b6a810d66c88ceab577eb37db93be5e25379f3fe Mon Sep 17 00:00:00 2001 From: A-Baji Date: Wed, 28 Sep 2022 14:32:07 -0500 Subject: [PATCH 3/4] changlelog --- CHANGELOG.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4451f8a..16214bd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,8 +8,6 @@ Observes [Semantic Versioning](https://semver.org/spec/v2.0.0.html) standard and - Component type check condition to allow form POST route overriding -### Added - ## [0.5.1] - 2022-09-27 ### Added From a4f48d89803448858384a23ab9fe22cb2af014f2 Mon Sep 17 00:00:00 2001 From: A-Baji Date: Wed, 28 Sep 2022 14:37:32 -0500 Subject: [PATCH 4/4] split on first --- pharus/dynamic_api_gen.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pharus/dynamic_api_gen.py b/pharus/dynamic_api_gen.py index 2d02b88..83a489a 100644 --- a/pharus/dynamic_api_gen.py +++ b/pharus/dynamic_api_gen.py @@ -127,7 +127,7 @@ def {method_name}() -> dict: (active_route_template).format( route=comp["route"], rest_verb="POST" - if comp["type"].split(":")[0] == "form" + if comp["type"].split(":", 1)[0] == "form" else "GET", method_name=comp["route"].replace("/", ""), component_type=comp["type"], @@ -135,7 +135,7 @@ def {method_name}() -> dict: component=json.dumps(comp), static_config=static_config, payload="payload=request.get_json()" - if comp["type"].split(":")[0] == "form" + if comp["type"].split(":", 1)[0] == "form" else "", method_name_type="dj_query_route", )