Fixes to allow the code to compile with Swift 2.0 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Failable initializers can’t override non-failable initializers - observeValueForKeyPath’s signature didn’t match the signature of the method it was overriding
| @@ -828,8 +828,7 @@ public class ChartViewBase: UIView, ChartAnimatorDelegate | |||
| internal typealias VoidClosureType = () -> () | |||
| internal var _sizeChangeEventActions = [VoidClosureType]() | |||
|
|
|||
| override public func observeValueForKeyPath(keyPath: String?, ofObject object: AnyObject?, change: [String: AnyObject]?, context: UnsafeMutablePointer<Void>) | |||
| { | |||
| public override func observeValueForKeyPath(keyPath: String?, ofObject object: AnyObject?, change: [NSObject : AnyObject]?, context: UnsafeMutablePointer<Void>) { | |||
There was a problem hiding this comment.
Please make sure to preserve code styling of the framework :)
(and I missed on failable initializer)
|
Oops, sorry about that :-) |
danielgindi
added a commit
that referenced
this pull request
Jul 22, 2015
Fixes to allow the code to compile with Swift 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method it was overriding