Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix programatical unhighlighting for BarCharView #3159

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

jekahy
Copy link
Contributor

@jekahy jekahy commented Jan 7, 2018

There was an issue with reseting the highlight manually from code. The lastHighlighted property of ChartViewBase was not set to nil. Thus, calling chartView.highlightValue(nil) in the delegate method chartValueSelected( chartView: entry: highlight:)_ did not do anything, and the next time user tapped a bar the chartValueNothingSelected method was called instead of the intended chartValueSelected.

@codecov-io
Copy link

Codecov Report

Merging #3159 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
- Coverage   22.97%   22.97%   -0.01%     
==========================================
  Files         116      116              
  Lines       15534    15535       +1     
  Branches      271      271              
==========================================
  Hits         3569     3569              
- Misses      11929    11930       +1     
  Partials       36       36
Impacted Files Coverage Δ
Source/Charts/Charts/BarLineChartViewBase.swift 22.56% <0%> (ø) ⬆️
Source/Charts/Charts/ChartViewBase.swift 22.09% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05ed02...4f82461. Read the comment docs.

@jjatie jjatie added this to the 3.1 milestone Jan 12, 2018
@jjatie
Copy link
Collaborator

jjatie commented Jan 12, 2018

Thanks!

@jjatie jjatie merged commit fc21586 into ChartsOrg:master Jan 12, 2018
@ChartsOrg ChartsOrg locked as resolved and limited conversation to collaborators Jan 12, 2018
lastHighlighted = h
highlightValue(h, callDelegate: true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we change the order here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants