Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for setting a custom width that is wider than the longe… #107

Merged
merged 1 commit into from
May 27, 2015
Merged

Conversation

AlBirdie
Copy link
Contributor

This adds support to set a custom width to an y axis as described in #92 .
Note that this only works with values that are greater than the longest label width.
It takes the max from the longest label and the custom width.

What do we need this for? If you've got several charts that share the same x values vertically stacked in a view, setting a common y axis width based on the widest y axis not only looks nicer, it also allows you to get away with a single x axis (that is, in case the chart ranges are kept in sync of course).

@AlBirdie
Copy link
Contributor Author

bildschirmfoto 2015-05-26 um 19 13 47

Like this, basically.

@danielgindi
Copy link
Collaborator

I'm improving it to have a max and a min width, and then merging it in.
By the way, you should really make branches for your PRs, so you can have separate PRs. (Create a branch, make whatever changes, create PR. Then go back and branch from the same spot and make another)

@AlBirdie
Copy link
Contributor Author

Ok, sounds even better.
Regarding the branching, do you have any difficulties with merging these pull requests the way I do them now? I usually pull from your master branch before implementing my changes and create the pull request from that, so (ideally) there shouldn't be any conflicts when you merge them, at least I hope so.
However, if branching makes it easier for you, then I'll do that of course.

@danielgindi
Copy link
Collaborator

No it is meant to make it easier for you, so you are not "stuck" waiting for a PR to go through...

@danielgindi danielgindi merged commit 0b76972 into ChartsOrg:master May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants