Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Colors Should Support Dark Mode [iOS 13] #4133

Closed
swupnil opened this issue Sep 3, 2019 · 5 comments
Closed

Default Colors Should Support Dark Mode [iOS 13] #4133

swupnil opened this issue Sep 3, 2019 · 5 comments

Comments

@swupnil
Copy link

swupnil commented Sep 3, 2019

What did you do?

ℹ Run project in Xcode 11, on a iOS 13 device.

What did you expect to happen?

ℹ Black text should invert to white (i.e. Charts should use UIColor.label instead of UIColor.black).

What happened instead?

ℹ Black text remains black.

Charts Environment

Charts version/Branch/Commit Number: 3.2.1
Xcode version: 11.0
Swift version: 4
Platform(s) running Charts: iOS
macOS version running Xcode: 10.14.4

@liuxuan30
Copy link
Member

a pull request is always wanted!

@ybeapps
Copy link

ybeapps commented Apr 15, 2020

Those merged commits are very important now since Apple announced that they won't keep apps that don't compile with iOS 13.0 SDK.
Now we want Charts to give us the labels colors for free..
Are you going to make a release soon?
Thanks!!

@liuxuan30
Copy link
Member

@ybeapps what you mean? The label colors already support Dark mode, see #4171 is merged above?

@ybeapps
Copy link

ybeapps commented Apr 16, 2020

I meant that those changes aren’t “released” yet in a new version
If I install from cocoapods I won’t get it.

@liuxuan30
Copy link
Member

I pushed a new version.

I personally suggest if you like to try new stuff, use swift package or carthage, not relying on we build it for pods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants