Bug. App fully hang during silent renew. #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 11, 2021 10:36
Added elapsed time check for silent renew check process. Implemented retry mechanism with timeout on first authentication check
Fixed checkAuthIncludingServer retry mechanism.
Fully covered by unit tests.
# Conflicts: # package-lock.json # projects/angular-auth-oidc-client/src/lib/callback/refresh-session.service.spec.ts # projects/angular-auth-oidc-client/src/lib/callback/refresh-session.service.ts
|
This is massive. A nice improvement. Thank you! Can you add the param |
|
Thanks. @damienbod stage is yours. Code looks fine to me. @Expelz Thank you very much. |
FabianGosebrink
approved these changes
Jan 19, 2021
|
@FabianGosebrink, Thanks! Glad I was able to contribute. |
|
@Expelz Thanks for this! This has been released now in version 11.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reset mechanism on silent renew check.
Added silent renew timeout configuration value into oidc config.
Implemented retry mechanism on timeout error during forceRefreshSession.
Fully covered by unit tests.
Related issues: #845, #934.