-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Table components not passing the 'key' prop to children of lists #208
Merged
benjitrosch
merged 1 commit into
daisyui:main
from
Klaas058:klaas058/fix-table-map-keys
Sep 11, 2022
Merged
Fix the Table components not passing the 'key' prop to children of lists #208
benjitrosch
merged 1 commit into
daisyui:main
from
Klaas058:klaas058/fix-table-map-keys
Sep 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for react-daisyui processing.
|
1 similar comment
👷 Deploy Preview for react-daisyui processing.
|
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
heschong
approved these changes
Sep 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I tested this locally and the errors are gone. Great work
benjitrosch
approved these changes
Sep 11, 2022
This was referenced Sep 11, 2022
This was referenced Oct 31, 2022
This was referenced Dec 30, 2022
This was referenced Apr 4, 2023
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component: Table
Issue: Table component not passing 'key' prop to children of lists #204
Fix the Table components not passing the 'key' prop to children of lists